From 341c08d7c32e539da6246b05ce55c6fe6343b79d Mon Sep 17 00:00:00 2001 From: Benjamin Peterson Date: Wed, 31 May 2017 10:15:44 +0200 Subject: fix signedness warnings in blaze_util_posix.cc if (result != count) { ~~~~~~~^~~~~~~~ Of course, problems arising from this are only theoretical. Change-Id: Id045a97623026e005d40940eb4a7d30d73f4ce32 PiperOrigin-RevId: 157561218 --- src/main/cpp/blaze_util_posix.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/main/cpp') diff --git a/src/main/cpp/blaze_util_posix.cc b/src/main/cpp/blaze_util_posix.cc index 0ccf966972..d5aa37b2dc 100644 --- a/src/main/cpp/blaze_util_posix.cc +++ b/src/main/cpp/blaze_util_posix.cc @@ -148,7 +148,7 @@ string GetJavaBinaryUnderJavabase() { return "bin/java"; } // binary anyway. const char** ConvertStringVectorToArgv(const vector& args) { const char** argv = new const char*[args.size() + 1]; - for (int i = 0; i < args.size(); i++) { + for (size_t i = 0; i < args.size(); i++) { argv[i] = args[i].c_str(); } @@ -276,7 +276,7 @@ static void ReadFromFdWithRetryEintr( do { result = read(fd, buf, count); } while (result < 0 && errno == EINTR); - if (result != count) { + if (result < 0 || static_cast(result) != count) { DieAfterFork(error_message); } } @@ -291,7 +291,7 @@ static void WriteToFdWithRetryEintr( // Darwin. result = write(fd, buf, count); } while (result < 0 && errno == EINTR); - if (result != count) { + if (result < 0 || static_cast(result) != count) { DieAfterFork(error_message); } } -- cgit v1.2.3