From 7bd3c81a05f97c6018bf6d1d4dfcd4e150f91407 Mon Sep 17 00:00:00 2001 From: Laurent Le Brun Date: Sat, 18 Feb 2017 04:18:59 +0000 Subject: Update doc wrt set vs depset. -- PiperOrigin-RevId: 147908180 MOS_MIGRATED_REVID=147908180 --- site/versions/master/docs/skylark/aspects.md | 2 +- site/versions/master/docs/skylark/cookbook.md | 2 +- site/versions/master/docs/skylark/rules.md | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) (limited to 'site/versions') diff --git a/site/versions/master/docs/skylark/aspects.md b/site/versions/master/docs/skylark/aspects.md index ee854ad496..4d575e9c4e 100644 --- a/site/versions/master/docs/skylark/aspects.md +++ b/site/versions/master/docs/skylark/aspects.md @@ -122,7 +122,7 @@ def _metal_proto_aspect_impl(target, ctx): argument = ... inputs = proto_sources outputs = outputs) - transitive_outputs = set(outputs) + transitive_outputs = depset(outputs) for dep in ctx.rule.attr.deps: transitive_outputs = transitive_outputs | dep.metal_proto.transitive_outputs return struct( diff --git a/site/versions/master/docs/skylark/cookbook.md b/site/versions/master/docs/skylark/cookbook.md index b011eee1ea..4e173645d4 100644 --- a/site/versions/master/docs/skylark/cookbook.md +++ b/site/versions/master/docs/skylark/cookbook.md @@ -861,7 +861,7 @@ other rules. For example, if you need to compile C++ files, you can reuse ```python def _impl(ctx): # Aggregate the output files from the depending rules - files = set() + files = depset() files += ctx.attr.dep_rule_1.files files += ctx.attr.dep_rule_2.files return struct(files=files) diff --git a/site/versions/master/docs/skylark/rules.md b/site/versions/master/docs/skylark/rules.md index 61f80edbe5..f82c5a38ca 100644 --- a/site/versions/master/docs/skylark/rules.md +++ b/site/versions/master/docs/skylark/rules.md @@ -203,7 +203,7 @@ If left unspecified, it will contain all the declared outputs. ```python def _impl(ctx): # ... - return struct(files=set([file1, file2])) + return struct(files=depset([file1, file2])) ``` This can be useful for exposing files generated with @@ -330,7 +330,7 @@ Providers are created from the return value of the rule implementation function: def rule_implementation(ctx): ... return struct( - transitive_data=set(["a", "b", "c"]) + transitive_data=depset(["a", "b", "c"]) ) ``` @@ -340,7 +340,7 @@ depended upon: ```python def dependent_rule_implementation(ctx): ... - s = set() + s = depset() for dep_target in ctx.attr.deps: # Use `print(dir(dep_target))` to see the list of providers. s += dep_target.transitive_data @@ -367,7 +367,7 @@ transitively from the rule's dependencies: ```python def rule_implementation(ctx): ... - transitive_runfiles = set() + transitive_runfiles = depset() for dep in ctx.attr.special_dependencies: transitive_runfiles += dep.transitive_runtime_files -- cgit v1.2.3