From 7d265e07e7a1e37f04d53342710e4f21d9ee8083 Mon Sep 17 00:00:00 2001 From: Damien Martin-Guillerez Date: Fri, 1 Jul 2016 13:33:48 +0000 Subject: Add all the sources to //:srcs filegroup and add a check to detect missing file to it. We need to activate this check on presubmits -- Change-Id: Ia95e92d3816ce92bb69bc0e2cf56e9c60b68d970 Reviewed-on: https://bazel-review.googlesource.com/#/c/3949/ MOS_MIGRATED_REVID=126404792 --- examples/BUILD | 4 +++- examples/android/java/bazel/BUILD | 6 ++++++ examples/cpp/BUILD | 5 +---- examples/j2objc/BUILD | 6 +----- examples/java-native/BUILD | 2 +- examples/java-skylark/BUILD | 2 +- examples/shell/BUILD | 2 +- 7 files changed, 14 insertions(+), 13 deletions(-) (limited to 'examples') diff --git a/examples/BUILD b/examples/BUILD index 781c81a46c..b2ec2848e8 100644 --- a/examples/BUILD +++ b/examples/BUILD @@ -2,11 +2,13 @@ package(default_visibility = ["//visibility:public"]) filegroup( name = "srcs", - srcs = [ + srcs = glob(["**"]) + [ + "//examples/android/java/bazel:srcs", "//examples/cpp:srcs", "//examples/gen:srcs", "//examples/java-native:srcs", "//examples/java-skylark:srcs", + "//examples/j2objc:srcs", "//examples/objc:srcs", "//examples/py:srcs", "//examples/py_native:srcs", diff --git a/examples/android/java/bazel/BUILD b/examples/android/java/bazel/BUILD index 293fb5dd45..ad550b5494 100644 --- a/examples/android/java/bazel/BUILD +++ b/examples/android/java/bazel/BUILD @@ -1,3 +1,9 @@ +filegroup( + name = "srcs", + srcs = glob(["**"]), + visibility = ["//examples:__pkg__"], +) + android_library( name = "lib", srcs = ["Lib.java"], diff --git a/examples/cpp/BUILD b/examples/cpp/BUILD index 7c0543e1f4..3048a0d48e 100644 --- a/examples/cpp/BUILD +++ b/examples/cpp/BUILD @@ -26,8 +26,5 @@ cc_test( filegroup( name = "srcs", - srcs = ["BUILD"] + glob([ - "**/*.cc", - "**/*.h", - ]), + srcs = glob(["**"]), ) diff --git a/examples/j2objc/BUILD b/examples/j2objc/BUILD index 41c7bb740a..0a3d3894cf 100644 --- a/examples/j2objc/BUILD +++ b/examples/j2objc/BUILD @@ -42,10 +42,6 @@ objc_binary( filegroup( name = "srcs", - srcs = glob([ - "J2ObjcExample/*", - "src/**", - "BUILD", - ]), + srcs = glob(["**"]), visibility = ["//examples:__pkg__"], ) diff --git a/examples/java-native/BUILD b/examples/java-native/BUILD index b698a88145..4f4ecd107d 100644 --- a/examples/java-native/BUILD +++ b/examples/java-native/BUILD @@ -2,7 +2,7 @@ package(default_visibility = ["//visibility:public"]) filegroup( name = "srcs", - srcs = [ + srcs = glob(["**"]) + [ "//examples/java-native/src/main/java/com/example/myproject:srcs", "//examples/java-native/src/main/resources:srcs", "//examples/java-native/src/test/java/com/example/myproject:srcs", diff --git a/examples/java-skylark/BUILD b/examples/java-skylark/BUILD index 9a76f2b0e9..74541aede1 100644 --- a/examples/java-skylark/BUILD +++ b/examples/java-skylark/BUILD @@ -2,7 +2,7 @@ package(default_visibility = ["//visibility:public"]) filegroup( name = "srcs", - srcs = [ + srcs = glob(["**"]) + [ "//examples/java-skylark/src/main/java/com/example/myproject:srcs", "//examples/java-skylark/src/main/resources:srcs", "//examples/java-skylark/src/test/java/com/example/myproject:srcs", diff --git a/examples/shell/BUILD b/examples/shell/BUILD index 9aba320bc2..4b51df1cb3 100644 --- a/examples/shell/BUILD +++ b/examples/shell/BUILD @@ -24,5 +24,5 @@ sh_test( filegroup( name = "srcs", - srcs = ["BUILD"] + glob(["**/*.sh"]) + glob(["**/*.txt"]), + srcs = glob(["**"]), ) -- cgit v1.2.3