From 7fc3410f21be3326325fc297ec86f0c79a091d01 Mon Sep 17 00:00:00 2001 From: robinnabel Date: Thu, 22 Mar 2018 07:18:14 -0700 Subject: Local Disk Cache: Only write to disk if target hash doesn't already exist. Under Windows, the default permissions used when writing to the local disk cache prevent the files from being overwritten. This CR adds a check: if the target file already exists, return early. This is a performance improvement and will fix the error described above as existing files will no longer need to be overwritten. Similar features have been implemented on the remote gRPC cache implementations, see bazel issue #4789. Closes #4886. PiperOrigin-RevId: 190060233 --- CONTRIBUTORS | 1 + 1 file changed, 1 insertion(+) (limited to 'CONTRIBUTORS') diff --git a/CONTRIBUTORS b/CONTRIBUTORS index 854e7d7733..768dbb5910 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -103,3 +103,4 @@ Yue Gan Yun Peng Dmitry Babkin Klaus Aehlig +Robin Nabel -- cgit v1.2.3