From b7bc525b48b83ebbb1c5a6b8187dcf10ae15c698 Mon Sep 17 00:00:00 2001 From: Ulf Adams Date: Thu, 24 Nov 2016 11:41:19 +0000 Subject: Update coverage documentation. Prepare for open sourcing CoverageCommand. Progress on #1118. -- MOS_MIGRATED_REVID=140121703 --- .../build/lib/analysis/config/BuildConfiguration.java | 5 ++--- .../build/lib/rules/test/CoverageReportActionFactory.java | 12 +++--------- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java index 1abd5fca84..d96f60997d 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java @@ -505,9 +505,8 @@ public final class BuildConfiguration { help = "Stamp binaries with the date, username, hostname, workspace information, etc.") public boolean stampBinaries; - // TODO(bazel-team): delete from OSS tree - // This default value is always overwritten in the case of "blaze coverage" by - // CoverageCommand.setDefaultInstrumentationFilter() + // This default value is always overwritten in the case of "bazel coverage" by + // CoverageCommand.setDefaultInstrumentationFilter(). @Option(name = "instrumentation_filter", converter = RegexFilter.RegexFilterConverter.class, defaultValue = "-/javatests[/:]", diff --git a/src/main/java/com/google/devtools/build/lib/rules/test/CoverageReportActionFactory.java b/src/main/java/com/google/devtools/build/lib/rules/test/CoverageReportActionFactory.java index 621b352f31..0cd02d2700 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/test/CoverageReportActionFactory.java +++ b/src/main/java/com/google/devtools/build/lib/rules/test/CoverageReportActionFactory.java @@ -23,25 +23,19 @@ import com.google.devtools.build.lib.actions.ArtifactOwner; import com.google.devtools.build.lib.analysis.BlazeDirectories; import com.google.devtools.build.lib.analysis.ConfiguredTarget; import com.google.devtools.build.lib.events.EventHandler; - import java.util.Collection; - import javax.annotation.Nullable; /** * A factory class to create coverage report actions. */ public interface CoverageReportActionFactory { - /** - * Wraps the necessary actions to get a coverage report as well as the final - * output artifacts. - * The lcovWriteAction creates a file containing a set of lcov files. - * This file is used as an input artifact for coverageReportAction. - * We are only interested about the output artifacts from + * Wraps the necessary actions to get a coverage report as well as the final output artifacts. + * The lcovWriteAction creates a file containing a set of lcov files. This file is used as an + * input artifact for coverageReportAction. We are only interested about the output artifacts from * coverageReportAction. */ - public static final class CoverageReportActionsWrapper { private final ActionAnalysisMetadata lcovWriteAction; private final ActionAnalysisMetadata coverageReportAction; -- cgit v1.2.3