From 6e0efe16d4bf40a3472d20769fc9f5b8fcadfe07 Mon Sep 17 00:00:00 2001 From: Janak Ramakrishnan Date: Thu, 12 Jan 2017 20:50:55 +0000 Subject: Add some logging in case we fail an evaluation. This should be generally useful, but may also help identify Bazel as the culprit in the linked bug if we're lucky and the timestamps are clear. -- PiperOrigin-RevId: 144359628 MOS_MIGRATED_REVID=144359628 --- .../com/google/devtools/build/skyframe/ParallelEvaluator.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java index 727b8395e9..7f6b62384f 100644 --- a/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java +++ b/src/main/java/com/google/devtools/build/skyframe/ParallelEvaluator.java @@ -45,6 +45,7 @@ import java.util.Map; import java.util.Map.Entry; import java.util.Set; import java.util.concurrent.ForkJoinPool; +import java.util.logging.Logger; import javax.annotation.Nullable; /** @@ -79,6 +80,8 @@ import javax.annotation.Nullable; * evaluation implementations outside of this package. */ public final class ParallelEvaluator implements Evaluator { + private static final Logger logger = Logger.getLogger(ParallelEvaluator.class.getName()); + private final ProcessableGraph graph; /** An general interface for {@link ParallelEvaluator} to receive objects of type {@code T}. */ @@ -389,6 +392,12 @@ public final class ParallelEvaluator implements Evaluator { // This is not the first error encountered, so we ignore it so that we can terminate // with the first error. return; + } else { + logger.warning( + "Aborting evaluation due to " + + builderException + + " while evaluating " + + skyKey); } } -- cgit v1.2.3