From 6980f84690a3419d1a49016e2a34c783a1064319 Mon Sep 17 00:00:00 2001 From: Lukacs Berki Date: Fri, 1 Apr 2016 15:48:59 +0000 Subject: Remove BuildConfiguration#supportsIncrementalBuild , which is apparently unused. BuildConfiguration.Fragment is much more complicated than it should be. Every little helps. -- MOS_MIGRATED_REVID=118783105 --- .../build/lib/analysis/config/BuildConfiguration.java | 19 ------------------- .../build/lib/rules/cpp/CppConfiguration.java | 5 ----- 2 files changed, 24 deletions(-) diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java index 9935a305b9..49740ecdc3 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java @@ -241,13 +241,6 @@ public final class BuildConfiguration { return ""; } - /** - * Return false if incremental build is not possible for some reason. - */ - public boolean supportsIncrementalBuild() { - return true; - } - /** * Return true if the fragment performs static linking. This information is needed for * lincence checking. @@ -2393,18 +2386,6 @@ public final class BuildConfiguration { return options.cpu; } - /** - * Returns true is incremental builds are supported with this configuration. - */ - public boolean supportsIncrementalBuild() { - for (Fragment fragment : fragments.values()) { - if (!fragment.supportsIncrementalBuild()) { - return false; - } - } - return true; - } - /** * Returns true if the configuration performs static linking. */ diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java index b9be3cb58f..e3be6f5b27 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java +++ b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppConfiguration.java @@ -1996,11 +1996,6 @@ public class CppConfiguration extends BuildConfiguration.Fragment { return getToolchainIdentifier(); } - @Override - public boolean supportsIncrementalBuild() { - return !isLipoOptimization(); - } - @Override public boolean performsStaticLink() { return getLinkOptions().contains("-static"); -- cgit v1.2.3