From 1a1c7f6f25af3be17fc4f97a3308d54d70d74f23 Mon Sep 17 00:00:00 2001
From: Googler <noreply@google.com>
Date: Mon, 25 Jul 2016 14:43:53 +0000
Subject: Optimize Rule.getLabels(void) to avoid
 ImmutableSortedSet.construct(). This is called only from
 Package$Builder.checkForInputOutputConflicts() which just wants the name of
 each input label; there's no need to sort or deduplicate.

--
MOS_MIGRATED_REVID=128355375
---
 src/main/java/com/google/devtools/build/lib/packages/Rule.java | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/main/java/com/google/devtools/build/lib/packages/Rule.java b/src/main/java/com/google/devtools/build/lib/packages/Rule.java
index 77cc19db9b..02971e08bb 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/Rule.java
+++ b/src/main/java/com/google/devtools/build/lib/packages/Rule.java
@@ -374,7 +374,14 @@ public final class Rule implements Target, DependencyFilter.AttributeInfoProvide
    * Returns a new List instance containing all direct dependencies (all types).
    */
   public Collection<Label> getLabels() {
-    return getLabels(DependencyFilter.ALL_DEPS);
+    final List<Label> labels = Lists.newArrayList();
+    AggregatingAttributeMapper.of(this).visitLabels(new AttributeMap.AcceptsLabelAttribute() {
+      @Override
+      public void acceptLabelAttribute(Label label, Attribute attribute) {
+        labels.add(label);
+      }
+    });
+    return labels;
   }
 
   /**
-- 
cgit v1.2.3