| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
| |
Fixes #5263
RELNOTES: execution strategies line no longer handles differently the case
where all processes have the same strategy.
PiperOrigin-RevId: 198057496
|
|
|
|
| |
PiperOrigin-RevId: 198053509
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Crashes lots of targets in nightly blaze-2018.05.24-1:
PiperOrigin-RevId: 198049395
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Crashes lots of targets in nightly blaze-2018.05.24-1:
PiperOrigin-RevId: 198041861
|
|
|
|
|
| |
RELNOTES:none
PiperOrigin-RevId: 198025150
|
|
|
|
|
|
|
| |
Instead,defer to ActionFS regarding the choice about delegation to top-level Filesystem.
RELNOTES: None
PiperOrigin-RevId: 197960416
|
|
|
|
|
|
|
| |
Also refactor away SkylarkModule.Resolver.
RELNOTES: None
PiperOrigin-RevId: 197955164
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 197949354
|
|
|
|
|
|
|
|
|
| |
well-defined.
Moving forward, if a class not already annotated with @SkylarkModule has SkylarkModule supertypes A and B, then it must be the case that A is a type of B, or B is a type of A. The skylark type of a given class is dictated by the *most specific* superclass annotated with @SkylarkModule.
RELNOTES: None.
PiperOrigin-RevId: 197946898
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's more efficient to use properly sized array builders to avoid having
a need to dynamically adjust the size of the underlying array. The result
is improved performance (no need to copy elements to newly created array)
and better memory efficiency - no need to re-allocate and no extra space
is wasted.
Closes #5241.
PiperOrigin-RevId: 197946723
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 197941930
|
|
|
|
|
|
|
| |
with generic parameters
RELNOTES: None.
PiperOrigin-RevId: 197932265
|
|
|
|
| |
PiperOrigin-RevId: 197924560
|
|
|
|
|
|
| |
diagnosing of bloat.
PiperOrigin-RevId: 197915327
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 197915097
|
|
|
|
|
|
|
| |
and [AndroidResourcesInfo].r_txt to Skylark.
RELNOTES: none
PiperOrigin-RevId: 197902129
|
|
|
|
|
|
| |
should not exist.
PiperOrigin-RevId: 197895718
|
|
|
|
|
|
| |
Part of https://docs.google.com/document/d/1_UJKmAQ9EE8i3Pl0il3YLTYr-Q9EKYYyLatt2zohfyM/edit#
PiperOrigin-RevId: 197890685
|
|
|
|
|
|
|
|
|
|
|
|
| |
A bug in the lexer ignored indentation on the first line of a file. This now
causes an error.
Also, remove the COMMENT token from the lexer. Comments are now accessed separately. This will allow further optimizations in the lexer. It also aligns the code a bit more with the Go implementation.
RELNOTES[INC]:
Indentation on the first line of a file was previously ignored. This is now fixed.
PiperOrigin-RevId: 197889775
|
|
|
|
|
|
|
|
| |
Netty's HttpClientCodec always emits a LastHttpContent event and so we don't need to track the received bytes manually to know when we are done reading. The HttpBlobStore compares the hashes of the received bytes to give us confidence that what we received is correct.
Closes #5244.
PiperOrigin-RevId: 197887877
|
|
|
|
|
|
|
|
|
|
|
| |
The Android data Skylark API includes references to FileProvider. To move that
API to the skylarkbuildapi, we must first move this provider.
For more information about this migration, see
https://docs.google.com/document/d/1UDEpjP_qWQRYsPRvx7TOsdB8J4o5khfhzGcWplW7zzI/
RELNOTES: none
PiperOrigin-RevId: 197882296
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 197881012
|
|
|
|
|
|
|
|
| |
Split the AnalysisFailureEvent into a legacy and a new variant; always post an
AnalysisFailureEvent, even if the legacy variant is not posted - this gives us
some coverage for loading failures.
PiperOrigin-RevId: 197862257
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'srcs') as textually included headers.
A private header is never exported to a different module and thus cannot be
used by a different module. We never need to compile a module just because one
of it's private headers is used from somewhere else. There must be a different
cc_library (and thus module) that exports the header.
At the same time, being compiled into a module doesn't provide benefits for the
compilation of that cc_library itself, because a module created for a
cc_library A is never used when compiling any of A's srcs.
PiperOrigin-RevId: 197846388
|
|
|
|
|
|
| |
construction. Also restrict visibility of some test-only OptionsDiff methods, and remove a server-specific part of the ConfiguredTargetKey #toString representation.
PiperOrigin-RevId: 197830577
|
|
|
|
|
|
| |
Part of https://docs.google.com/document/d/1_UJKmAQ9EE8i3Pl0il3YLTYr-Q9EKYYyLatt2zohfyM/edit#
PiperOrigin-RevId: 197800831
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 197799961
|
|
|
|
|
| |
RELNOTES: --batch is deprecated
PiperOrigin-RevId: 197780675
|
|
|
|
|
|
| |
This is going away with the removal of C++ LIPO support.
PiperOrigin-RevId: 197779736
|
|
|
|
|
|
| |
This results in less special logic in the implementation and a simpler API.
PiperOrigin-RevId: 197772283
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I've pulled out the API for separate review. It includes all
hooks from blaze/skylark used by the debugger.
Debuggable thread contexts are currently declared in 3 places:
- BuildFileAST (top-level evaluation of BUILD files)
- SkylarkRuleConfiguredTargetUtil (rules)
- SkylarkAspectFactory (aspects)
The purpose of declaring these contexts is so that the debugger
can track currently-active threads (and stop tracking them when
the task is completed).
Details of the actual debugging server are in unknown commit.
PiperOrigin-RevId: 197770547
|
|
|
|
|
|
|
| |
This unclashes with the incoming ConfigurationTransition.apply
method described in https://docs.google.com/document/d/1_UJKmAQ9EE8i3Pl0il3YLTYr-Q9EKYYyLatt2zohfyM/edit#heading=h.96gongkwg852.
PiperOrigin-RevId: 197769784
|
|
|
|
|
|
|
|
| |
using C++ modules (yet) and thus we are paying some of the cost such as
building transitive modules and a taller critical path without reaping any
benefits.
PiperOrigin-RevId: 197768129
|
|
|
|
|
|
|
|
|
| |
With this change, all classes in com.google.testing.junit.runner.util will be loaded from the system classloader for robolectric tests.
This fixes a problem where TestPropertyExporter and TestIntegrationsRunnerIntegration in the com.google.testing.junit.runner.util package were being loaded twice: once by the test runner into the system classloader, and again into the robolectric's classloader during test execution. Since there were two separate instances, the test properties exported during robolectric's testing lifecycle were disconnected from the test runner which writes out the properties.
RELNOTES: none
PiperOrigin-RevId: 197761010
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 197744356
|
|
|
|
|
|
|
| |
build API to a global environment.
RELNOTES: None.
PiperOrigin-RevId: 197742427
|
|
|
|
|
|
|
| |
This abstraction is not needed anymore.
RELNOTES: None.
PiperOrigin-RevId: 197739700
|
|
|
|
|
|
|
|
|
|
| |
the mobile-install aspect to pickup and desugar+dex only runtime jars without
running a manual filter step (which breaks transitive_runtime_jars depset at
every level).
NOTE: The method that this one wraps was originially created for the native dex
aspect which will eventually be migrated to Skylark too.
PiperOrigin-RevId: 197739483
|
|
|
|
|
|
|
| |
This is needed for re-writing match_clif in Skylark.
RELNOTES:none
PiperOrigin-RevId: 197738067
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 197735344
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 197731580
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BusyBoxActionBuilder makes much cleaner action builders while making it harder
to do Bad Things (like collapsing NestedSets in analysis, or adding an artifact
to one of the command line and the inputs but not both).
Also:
- In merging, simplify the code somewhat by removing unneeded conditionals -
for example, the parsed merging action will always be built given the current
code.
- In the few builders where we aren't doing so already, parameter files should
always be shell quoted and always be used when the OS is Windows. The BusyBox
should always support the former and require the latter (although
sufficiently large inputs may have masked this by triggering parameter files
in Windows anyway).
- In the builder for linking (within validation), no longer collapse the
NestedSet of transitiveCompiledSymbols when adding them to the inputs. Using
the new BusyBoxActionBuilder code, trying to do this would throw an
IllegalStateException.
RELNOTES: none
PiperOrigin-RevId: 197728382
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove java support from proto_library.
NEW: Allow java_* rules to depend on proto_libraries via runtime_deps and exports. This should avoid the breakage that caused the original rollback. The edges are no-ops and could be removed.
*** Reason for rollback ***
Targets in the repository are still able to depend on proto_library rules
even after the --noemit_proto_java_outputs flag flip. Removal of the Java
support from proto_library breaks them.
PiperOrigin-RevId: 197725926
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Change introduced flakiness in //src/test/java/com/google/devtools/build/lib:actions_test
Verified the culprit commit using:
bazel test //src/test/java/com/google/devtools/build/lib:actions_test --runs_per_test=100 --notest_keep_going -t-
See https://github.com/bazelbuild/bazel/issues/5242.
*** Original change description ***
Relax the threshold for calling getDigestInExclusiveMode().
If the policy goal is to minimize disk seeks, this should be equally good.
RELNOTES: None.
PiperOrigin-RevId: 197720793
|
|
|
|
|
|
|
|
| |
Related issue: https://github.com/bazelbuild/bazel/issues/1013
Fix https://github.com/bazelbuild/bazel/issues/5243
RELNOTES:
PiperOrigin-RevId: 197715690
|
|
|
|
|
|
|
| |
support.
RELNOTES: None.
PiperOrigin-RevId: 197708692
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 197707463
|
|
|
|
|
|
|
|
| |
The constructors which don't accept an action environment should not be called,
with the exception of subclasses that don't run any subprocesses, and therefore
don't need an environment.
PiperOrigin-RevId: 197706734
|
|
|
|
|
|
|
|
|
|
| |
Prune down the list of attributes to the explicitly set ones when reporting
the original attributes. The attribute list also contains attributes implicitly
added from default values, but the original attributes are intended to record
the original way the rule was invoked from the WORKSPACE file.
Change-Id: I918656159850a52e9afc9f045701b0ea065f4125
PiperOrigin-RevId: 197702283
|