From 16661ba8c0103c2571e84a59a107c9e41dbe60dc Mon Sep 17 00:00:00 2001 From: Jeff McGlynn Date: Thu, 16 Aug 2018 16:53:26 -0700 Subject: Fix ASAN failures in integer_sequence_codec and partition Introduce UTILS_RELEASE_ASSERT, which crashes if the condition isn't met, even on release builds. Update integer_sequence_codec and partition to use the new tests to validate input parameters, and update the tests so that they expect the crash to occur even on release builds. Bug: 112691516, 112669735 Change-Id: Ic82edeffc64ca0f2b0d17f1c63563dfd8d9cdd71 --- src/decoder/test/integer_sequence_codec_test.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/decoder/test/integer_sequence_codec_test.cc') diff --git a/src/decoder/test/integer_sequence_codec_test.cc b/src/decoder/test/integer_sequence_codec_test.cc index b66ff2b..120e8b0 100644 --- a/src/decoder/test/integer_sequence_codec_test.cc +++ b/src/decoder/test/integer_sequence_codec_test.cc @@ -74,9 +74,8 @@ TEST(ASTCIntegerSequenceCodecTest, TestGetCountsForRange) { EXPECT_EQ(b, kExpectedCounts[i - 1][2]); } - ASSERT_DEBUG_DEATH(IntegerSequenceCodec::GetCountsForRange(0, &t, &q, &b), ""); - ASSERT_DEBUG_DEATH( - IntegerSequenceCodec::GetCountsForRange(256, &t, &q, &b), ""); + ASSERT_DEATH(IntegerSequenceCodec::GetCountsForRange(0, &t, &q, &b), ""); + ASSERT_DEATH(IntegerSequenceCodec::GetCountsForRange(256, &t, &q, &b), ""); IntegerSequenceCodec::GetCountsForRange(1, &t, &q, &b); EXPECT_EQ(t, 0); -- cgit v1.2.3