From c2e00d341913bf03b4597ade5b056042e23e8c58 Mon Sep 17 00:00:00 2001 From: Abseil Team Date: Wed, 25 Jul 2018 09:37:23 -0700 Subject: Export of internal Abseil changes. -- eb6cc81ef7e89e10fc9df47418af93e22fd116d2 by Abseil Team : Workaround clang bug https://bugs.llvm.org/show_bug.cgi?id=38289 PiperOrigin-RevId: 206006290 -- 509e9829295bfc429b82de42f2e073c756ea5709 by Jon Cohen : Remove make_unique ambiguity when using gcc 4.9 in C++14 mode. gcc 4.9.4 has __cplusplus at 201300L instead of 201402L when in C++14 mode, I guess indicating incomplete support. Anyways, it causes a problem with this check as in c++14 mode in old gcc we were defining absl::make_unique when std::make_unique was present PiperOrigin-RevId: 205886589 GitOrigin-RevId: eb6cc81ef7e89e10fc9df47418af93e22fd116d2 Change-Id: I9acf3f3d0fd3b0b46ae099821f3bf21b72c28b2b --- absl/strings/internal/str_format/float_conversion.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'absl/strings/internal/str_format/float_conversion.cc') diff --git a/absl/strings/internal/str_format/float_conversion.cc b/absl/strings/internal/str_format/float_conversion.cc index 37952b4..6176db9 100644 --- a/absl/strings/internal/str_format/float_conversion.cc +++ b/absl/strings/internal/str_format/float_conversion.cc @@ -153,7 +153,14 @@ void PrintExponent(int exp, char e, Buffer *out) { template constexpr bool CanFitMantissa() { - return std::numeric_limits::digits <= std::numeric_limits::digits; + return +#if defined(__clang__) && !defined(__SSE3__) + // Workaround for clang bug: https://bugs.llvm.org/show_bug.cgi?id=38289 + // Casting from long double to uint64_t is miscompiled and drops bits. + (!std::is_same::value || + !std::is_same::value) && +#endif + std::numeric_limits::digits <= std::numeric_limits::digits; } template -- cgit v1.2.3