From 9bdbf90830b0cae75484565e840655117b66a87b Mon Sep 17 00:00:00 2001
From: Jesse Hallett <jesse@galois.com>
Date: Tue, 7 Jan 2014 16:30:55 -0800
Subject: Modifies 'reflist' exception to inlineStyle rule

---
 guidelines/wikipedia/specs/inlineStyle_spec.js | 21 +++++++++++++++++++++
 guidelines/wikipedia/src/inlineStyle.js        |  3 ++-
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 guidelines/wikipedia/specs/inlineStyle_spec.js

diff --git a/guidelines/wikipedia/specs/inlineStyle_spec.js b/guidelines/wikipedia/specs/inlineStyle_spec.js
new file mode 100644
index 0000000..d41969c
--- /dev/null
+++ b/guidelines/wikipedia/specs/inlineStyle_spec.js
@@ -0,0 +1,21 @@
+describe('inlineStyle', function() {
+  var inline = rule('Do not use in-line styles');
+
+  afterEach(teardownFixtures);
+
+  it('reports error for elements with style attribute', function() {
+    var $p = fixture('<p style="color:darkgoldenrod">fancy text</p>');
+    var results = run(inline);
+    expect(results.errors.length).toEqual(1);
+    expect(results.errors[0].element).toEqual($p.get(0));
+  });
+
+  it('excludes reflist list-style-type from report', function() {
+    var $l = fixture(
+      '<div class="reflist" style="list-style-type: decimal;">references</div>'
+    );
+    var results = run(inline);
+    expect(results.errors.length).toEqual(0);
+    expect(results.warnings.length).toEqual(0);
+  });
+});
diff --git a/guidelines/wikipedia/src/inlineStyle.js b/guidelines/wikipedia/src/inlineStyle.js
index 261586d..342547a 100644
--- a/guidelines/wikipedia/src/inlineStyle.js
+++ b/guidelines/wikipedia/src/inlineStyle.js
@@ -9,6 +9,7 @@ exports.rule = function(report) {
 
 function excludes(i, elem) {
   var $elem = $(elem);
+  var style = $elem.attr('style');
 
   // Ignore width rules.
   var widthRule = everyStyle($elem, function(s) {
@@ -21,7 +22,7 @@ function excludes(i, elem) {
 
   // The standard reference list template also seems to include some
   // inline styles.
-  var reference = $elem.hasClass('reflist references-column-width') ||
+  var reference = ($elem.hasClass('reflist') && style.match(/list-style-type\s*:\s*decimal/)) ||
     $elem.hasClass('error') ||
     ($elem.is('.citation ~ * *') && !$.trim($elem.text())); // <span>&nbsp;</span>
 
-- 
cgit v1.2.3